fix infinite loop in cropping #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused about why the tests weren't already catching this! |
Probably because the tests weren't running against the latest rich version? |
|
I ran them locally and they all passed, even when the example failed when run manually (latest version of Rich installed) 🤷 |
darrenburns
approved these changes
Oct 22, 2024
|
Officially the weirdest bug I've encountered this week. Works with "a". Fails with "w", "x", "y", or "z" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5151
I think the issue was in
TextArea.render_line. The previous version ofSegment.split_cellswas buggy, but may have coicidentally done compensated for this bug.Segment.split_cellsshould probably also use an assert. Nobody likes an infinite loop.@darrenburns Could you take a quick look at this to make sure I'm on the right track? Can you suggest a test?