refactor: move webhook logic to class

src/index.mjs

@@ -1,4 +1,5 @@
 import { Device } from "./homewizard/device.mjs";
+import { Webhook } from "./webhooks/webhook.mjs";
 
 /**
  * energyid-homewizard-connector
@@ -61,6 +62,8 @@ const typeMap = [
 ];
 
 class Reading {
+	remoteName;
+
 	constructor(type, date, value) {
 		this.remoteId = type[1].id;
 		this.remoteName = type[1].name;
@@ -96,28 +99,19 @@ const setReadings = (data) => {
 
 const sendReadings = (readings, dryRun) => {
 	console.log(dryRun ? "Printing readings to console..." : "Sending readings to EnergyId Webhook...");
+	const webhook = new Webhook("EnergyId", energyid_hook, "POST");
+
 	for (const reading of readings) {
 		if (dryRun) {
 			console.log(`Reading to send: ${reading.json()}`);
 			return;
 		}
-		fetch(energyid_hook, {
-			method: "POST",
-			headers: {
-				Accept: "application/json",
-				"Content-Type": "application/json",
-			},
-			body: reading.json(),
-		})
-			.then((response) => {
-				if (!response.ok) {
-					throw new Error(`Error sending reading: ${reading.json()}`);
-				}
-				console.log(`Sending reading: ${reading.json()}`);
-			})
-			.catch((e) => {
-				console.error(e.message);
-			});
+
+		try {
+			webhook.send(reading.json());
+		} catch (e) {
+			// console.error(e.message);
+		}
 	}
 };
 

src/webhooks/webhook.mjs

@@ -0,0 +1,45 @@
+/**
+ * Webhook class
+ */
+
+const METHODS = new Set(["GET", "POST", "PUT", "PATCH", "DELETE"]);
+
+export class Webhook {
+	#name = "";
+	#url = "";
+	#method = ""; /**
+	 * Create a new Webhook instance
+	 * @param {*} name - Set a name for the webhook
+	 * @param {*} url - Set the URL of the webhook
+	 * @param {*} method - [optional] Set the method to use for the webhook (Default: GET)
+	 */
+	constructor(name, url, method = "GET") {
+		this.#name = name;
+		this.#url = url;
+		this.#method = METHODS.has(method.toUpperCase()) ? method.toUpperCase() : "GET";
+	}
+
+	send = async (data = "") => {
+		const jsonData = JSON.parse(data);
+		console.log(`[${this.#name}] Sending ${jsonData.remoteName || "data"}...`);
+
+		try {
+			const response = await fetch(this.#url, {
+				method: this.#method,
+				headers: {
+					Accept: "application/json",
+					"Content-Type": "application/json",
+				},
+				body: data,
+			});
+
+			if (!response.ok) {
+				throw new Error();
+			}
+
+			console.log(`[${this.#name}] Sent reading: ${reading.json()}`);
+		} catch (e) {
+			console.error(`[${this.#name}] Error sending reading: ${data}`);
+		}
+	};
+}