Use operator[] instead of front() in get_x5c_key_value to support jsoncpp #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `front()` with `[0]` as front is not supported by jsoncpp on array types. Signed-off-by: Omar Mohamed <[email protected]>
|
Would it be possible to implement the missing function in the trait definition? Extending, Also it seems we are missing this function as a requirement for the json array Line 2459 in 83703d7 |
This reverts commit dfa7d29.
Signed-off-by: Omar Mohamed <[email protected]>
|
Is |
|
Yes, Might also be fore checking if the unit tests are missing a case 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
front()with[0]inget_x5c_key_valueas front is not supported by jsoncpp on array types.