Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Merge pull request #10

wants to merge 3 commits into from

Conversation

Kaushkiraj
Copy link

For the first time, I am contributing to open source. Thanks a lot to all the member of Codesis.

@tushar5526
Copy link
Member

Hey @Kaushkiraj looks good to me. Try squashing your commits into one. Read this

adiaholic
adiaholic requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@adiaholic adiaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 things you need to take care of:

  1. Never use your master branch to push features. Instead you should make a branch on your fork: eg kaushikiraj/some-relevant-name. If you make PRs from the master branch, you won't be able to work on multiple issues simultaneously.
  2. The PR message Merge pull request doesn't carry any significant information. It is in best practise to write something which gives the reviewer a gist of what that PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiaholic adiaholic adiaholic requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaushkiraj @tushar5526 @adiaholic