Pagina registro #72
Merged
Pagina registro #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cambiando mayúscula por minúscula. Borrando comentarios.
El registro está casi listo Solo falta la verificación de contraseña dos veces. Además, añadí un comentario a un console.log(); que me confundió por un rato. Ahora todo está más claro en console.log()! 💻🔍
francosang
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Vamoooo @JLeonN !
Ahora acordate de seguir con el componente global:
francosang
reviewed
Apr 18, 2024
Comment on lines
12
to
29
| const btnRegistro = async () => { | ||
| if (email == "" || contraseña == "") { | ||
| setErrorVacio(true); | ||
| } else { | ||
| const reg = { | ||
| email: email, | ||
| password: contraseña, | ||
| }; | ||
| try { | ||
| await registro(reg); | ||
| navegar("/"); | ||
|
|
||
| } catch (error) { | ||
| // console.log(error.response.status); | ||
| setErrorRegistro(true); | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Al principio de esta funcion hay que poner los errores en false, porque si no al hacer click se quedan los errores anteriores.
There was a problem hiding this comment.
Esto después explícamelo cuando estemos conectados
francosang
reviewed
Apr 18, 2024
Comment on lines
59
to
70
| {/* <div className="campoLogin"> | ||
| <label htmlFor="password">Contraseña:</label> | ||
| <input | ||
| id="password" | ||
| type="password" | ||
| name="contrasena" | ||
| placeholder="Repita su contraseña" | ||
| required | ||
| value={contraseña} | ||
| onChange={(e) => setContraseña(e.target.value)} | ||
| /> | ||
| </div> */} |
There was a problem hiding this comment.
Esto no lo vas a dejar?
There was a problem hiding this comment.
Esto lo voy hacer ahora
y lo dejo pronto en esta PR
Me falta dar un mensaje que avise al usuario cuando las contraseñas no coinciden. 🛡️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.