Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convertir columna dia en tipo fecha #79

Merged
merged 5 commits into from
May 6, 2024
Merged

Convertir columna dia en tipo fecha #79

merged 5 commits into from
May 6, 2024

Conversation

francosang
Copy link
Collaborator

@francosang francosang commented May 5, 2024

Cambios

  • Cambia la columna dia al tipo date (fecha) con un nuevo script SQL.
  • Simplifica el codigo del servicio para que tome ventaja de la nueva columna.
  • Borra la libreria dayjs que ya no es necesaria.

Como revisar

  • Ignorar los cambios en package-lock.json
  • Verificar que dayjs fue eliminada de package.json
  • Revisar los cambios en tontos.service.js
  • Revisar el nuevo archivo SQL.

MallicTesla
MallicTesla previously approved these changes May 5, 2024
Copy link
Collaborator Author

@francosang francosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mierda, me acabo de dar cuenta que hay un problema!

No le den al merge!

sql/010_update_dia_column.sql Show resolved Hide resolved
JLeonN
JLeonN previously approved these changes May 6, 2024
@francosang francosang dismissed stale reviews from JLeonN and MallicTesla via df4f25f May 6, 2024 15:57
@francosang francosang merged commit 14d23d2 into main May 6, 2024
1 check passed
@francosang francosang deleted the update-dia-column branch May 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants