Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entries for MassGib everything #116

Closed
wants to merge 7 commits into from

Conversation

tomm1996
Copy link

Give Everything Except Weapons & Give All Weapons are separate for the purpose of mule creation & dropping armaments at a later point.

I tested the scripts and they seem to run nicely without crashing my client

  • Only Runs if isOwnDlc(1)
  • Gives Ashes of War three times
  • Does not give crafting materials due to max chest space issues

@inuNorii
Copy link
Member

I get the idea of "Give Everything except Weapons", but "Give All Weapons" is already in the table.

@tomm1996
Copy link
Author

@inuNorii fair. For me, it was just the inconvenience of having to do drop them over two separate scripts so I created it like that.
How would you feel about this:

  • Give everything
  • Give everything except weapons

So I could either make a lvl 1 build & copy it so I can decide later what Upgrade I want or just drop everything including weapons from the get-go. Would you agree with that?

@inuNorii
Copy link
Member

I have a different solution planned, but it'll take a while until I get around to implementing it. We had GUIs for MassItemGib in our Dark Souls III table and I intend to port those over at some point, removing the need for a lot of the split up scripts in MassItemGib.

Also changed line endings to CRLF
@tomm1996
Copy link
Author

Glad to hear you're working on a GUI, that's awesome! I updated the branch so it makes more sense, in case you want to use that until then. If not, just close the PR it's fine either way

@The-Grand-Archives The-Grand-Archives deleted a comment Sep 9, 2024
@inuNorii inuNorii deleted the branch The-Grand-Archives:dev October 3, 2024 09:49
@inuNorii inuNorii closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants