drt: pin access split #5945
drt: pin access split #5945
Conversation
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
…nction Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| T* pin, | ||
| std::unique_ptr<frPathSeg> ps, | ||
| frInstTerm* inst_term, | ||
| const Point point, |
There was a problem hiding this comment.
warning: parameter 'point' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const Point point, | |
| Point point, |
| T* pin, | ||
| std::unique_ptr<frPathSeg> ps, | ||
| frInstTerm* inst_term, | ||
| const Point point); |
There was a problem hiding this comment.
warning: parameter 'point' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const Point point); | |
| Point point); |
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #include <omp.h> |
There was a problem hiding this comment.
warning: 'omp.h' file not found [clang-diagnostic-error]
#include <omp.h>
^| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #include <omp.h> |
There was a problem hiding this comment.
warning: 'omp.h' file not found [clang-diagnostic-error]
#include <omp.h>
^| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #include <omp.h> |
There was a problem hiding this comment.
warning: 'omp.h' file not found [clang-diagnostic-error]
#include <omp.h>
^
This PR is waiting for every PA PR to merge, #5903.
This PR creates three new PA files, one for each of the
FlexPA_prep.cppresponsibilities:FlexPA_acc_point.cppFlexPA_acc_patterns.cppFlexPA_row_patterns.cppSome functions that couldn't be easily separated were kept in
FlexPA_prep.cpp, this might be due to being dependant to more than one of the new files or more than one of the new files depending on it.There might be a case for moving everything in
FlexPA_prep.cppto 'FlexPA.cpp' as now there are few functions left.I copied imports and copyright to new files. I commented any import that did not stop the project from compiling and running.
FlexPA_acc_point.cppis still big 1483 LOC so it might have to be split even further.