report_design_area: allow redirection to file #6046
Conversation
same as all other commands, don't know why this one slipped between the cracks Signed-off-by: Øyvind Harboe <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
| @@ -637,7 +637,7 @@ proc repair_timing { args } { | |||
|
|
|||
| sta::define_cmd_args "report_design_area" {} | |||
|
|
|||
| proc report_design_area { args } { | |||
There was a problem hiding this comment.
you need to update the define_cmd_args to reflect this change.
See:
OpenROAD/src/rsz/src/Resizer.tcl
Line 647 in 0fc26a3
There was a problem hiding this comment.
Getting some errors.
Running tapcell.tcl, stage 2_4_floorplan_tapcell
Error: TCL init script: invalid command name "wrong # args: should be "sta::proc_redirect proc_name body"
while executing
"sta::proc_redirect report_design_area { args } {
There was a problem hiding this comment.
looks like the proc_redirect indirectly defined args:
OpenROAD/src/rsz/src/Resizer.tcl
Line 649 in 0fc26a3
I think you just need to change it to sta::proc_redirect report_design_area {
There was a problem hiding this comment.
After a bit more hacking and
find tools/OpenROAD/ -regex .*tclInitVar.*.cc -exec rm {} \;
./build_openroad.sh --local --no_init
It compiles.
However "make do-2_1_floorplan" does not redirect yet...
$ make open_floorplan
ODB_FILE=./results/nangate45/gcd/base/2_floorplan.odb /home/oyvind/OpenROAD-flow-scripts/tools/install/OpenROAD/bin/openroad -no_init -threads 48 /home/oyvind/OpenROAD-flow-scripts/flow/scripts/open.tcl
OpenROAD v2.0-16809-g23f5678bc
Features included (+) or not (-): +Charts +GPU +GUI +Python : Debug
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[INFO ORD-0030] Using 48 thread(s).
GUI_TIMING=1 reading timing, takes a little while for large designs...
Populating timing paths...
openroad> report_design_area >ll.txt
Design area 663 u^2 58% utilization.
openroad> report_design_area >>ll.txt
Design area 663 u^2 58% utilization.
openroad>
$ cat ll.txt
There was a problem hiding this comment.
The issue seems to be that using utl::report bypasses the file redirect.
The same issue appears in the report_floating_nets it's possible that the redirect doesn't work correctly with the logger.
There was a problem hiding this comment.
I'm sitting tight for advice here, I have no idea what the intention is or what would be consistent in this code.
There was a problem hiding this comment.
I think the fix needs to be in a different PR (you might want to open an issue for tracking).
While this code doesn't work as intended until the underlying issue is resolved I don't think there is any harm in merging this in (just means to be able to use it it might take some time)
There was a problem hiding this comment.
One concern at the time, yes.
There was a problem hiding this comment.
@maliberty Can you check if it is a quick fix to address what @gadfort found or articulate a github issue? I'm a little bit vague on exactly what the problem is.
There was a problem hiding this comment.
it's somewhat involved...
The underlying issue is here:
OpenROAD/src/dbSta/src/dbSta.cc
Line 622 in a5e7128
Because the tcl code and STA directs all it's prints to this function we correctly redirect the code, in openroad, we use the logger directly and thus this is broken.
Signed-off-by: Øyvind Harboe <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Øyvind Harboe <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty Let me know if you want to move forward with this |
same as all other commands, don't know why this one slipped between the cracks