rsz: add detailed_routing as parasitics source #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
maliberty
reviewed
Oct 29, 2024
Comment on lines
297
to
299
| case ParasiticsSrc::detailed_routing: | ||
| parasitics_src_ = ParasiticsSrc::detailed_routing; | ||
| break; |
There was a problem hiding this comment.
Is it right that this does no estimation?
There was a problem hiding this comment.
The way I'm implementing it on ORFS, we already load the SPEF file after writing it with RCX, so no estimation is needed. Perhaps in the future we want to call rcx and load the spef data only in C++, and here would be a correct place for it.
Maybe I can add a comment about these future plans here?
Comment on lines
400
to
401
| case ParasiticsSrc::detailed_routing: | ||
| break; |
There was a problem hiding this comment.
Similar comment here. The idea is that the parasitics are already loaded in sta.
|
Even if you could ask sta if it has parasitics, it wouldn't know the source of them. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 29, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This first step only adds
detailed_routingas a new source of parasitics, and is used mainly to avoid calculating the parasitics from wire load models.In the first iteration on each net, the droute parasitics are used, but once the net is changed, later iterations will use the global routing parasitics for estimation. At some point we should be able to detail route again specific nets inside the repair_timing flow.
Last, I'm checking if the design is routed to define the parasitics source as detailed_routing. It doesn't seem the ideal way, but I didn't find any functions in STA to detect there are parasitics present in its internal structures. Another option would be have a command that the user explicitly calls to define detailed_routing as the parasitics source.
I'm open to suggestions on how to improve this part of the code.