mpl2: handle the track pattern more directly #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have multiple track patterns (eg m2 in asap7) the current code is wrong. This is a partial solution in that it just uses the first track pattern. Ideally it should consider snapping to any of the track patterns. The cost will be snapping further than needed. This "fixes" The-OpenROAD-Project#6267. Signed-off-by: Matt Liberty <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@AcKoucher @joaomai please work on a better fix for handling multiple patterns |
maliberty
approved these changes
Dec 15, 2024
|
@maliberty Opened #6360 for the enhancement work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple track patterns (eg m2 in asap7) the current code is wrong. This is a partial solution in that it just uses the first track pattern. Ideally it should consider snapping to any of the track patterns. The cost will be snapping further than needed.
This "fixes" #6267.