Use default name for the ORFS docker image #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the user can specify a locked down version themself for production. For local testing, the same docker tag as ORFS is convenient as that makes compiling a docker image from ORFS the regular way an obvious alternative to using "bazel run orfs_env" This begs the question as to why "bazel run orfs_env" now exists... Isn't that a CI concern for regression testing of bazel-orfs and not a user-concern? Users, such as megaboom, are responsible for publishing and specifying the docker tag and url or furnishing the docker image in some out of bounds way(such as compiling locally). Signed-off-by: Øyvind Harboe <[email protected]>
Use ORFS docker image built on top of [4ac2d011](The-OpenROAD-Project/OpenROAD-flow-scripts@4ac2d01) Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #22.
CC @oharboe