Make path to ORFS configurable #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce implicit dependency on `~/orfs_path.sh` script. It must declare `ORFS` environment variable with a path to local `OpenROAD-flow-scripts` installation. Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
oharboe
requested changes
Feb 26, 2024
There was a problem hiding this comment.
This is just kicking the can down the road.
We need a more satisfactory solution.
I think the answer is to stop fighting Bazel and go for a more idiomatic solution.
- add a docker url and version string in BUILD.bazel and use this in the build
- for local hacking, rely exclusively on the _make scripts.
|
This is an ./orfs equivalent example for building w docker. Copy and adapt here: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/flow/util/docker_shell |
|
Let's close this PR and focus on providing a solution that includes defining ORFS as an explicit Bazel dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the task of specifying path to ORFS outside of this repository and build systems that are used here.
It hardcodes an implicit dependency on
orfs_path.shscript which is expected to be placed in the home directory. The script must contain a definition ofORFSenvironment variable with a path to local installation ofOpenROAD-flow-script.This modification breaks bazel's hermeticity in order to allow changing the path to local ORFS installation without the need of rebuilding expensive targets.
Additionally, it is important to remember that changing version of ORFS, OpenROAD, yosys, etc., as well as any manual modification to the build system, TCL scripts, environment variables configuration and tools source code in the scope of ORFS repository will not cause invalidation of previous builds. It is the user's responsibility to rebuild artifacts when necessary to keep the integrity of the build after modifications made to local OpenROAD-flow-scripts setup.