-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add check_code_format.yml
#27
Conversation
8663d15
to
08c604b
Compare
Adding the debug output Here's an example output: logs |
8213e6b
to
c8b9f8c
Compare
33d0ee6
to
08c604b
Compare
Strange... the output does not appear in the actions logs:
EDIT: of course the output is empty... the files are already reformatted. I will use |
I see. I tried it out and it would work with
My logs: https://github.com/Ramy-Badr-Ahmed/Fortran-DSA/actions/runs/11043111068/job/30676793615 Let's have another try 🙂 |
Co-authored-by: Ramy <[email protected]>
8635f1f
to
f240af7
Compare
So as mentioned above: the output was empty, because obviously the files were already reformatted. I used Now it works as expected, cf. the failing case: https://github.com/TheAlgorithms/Fortran/actions/runs/11045781263/job/30683988597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's now very informative 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 !
This PR adds a workflow, which checks the used code formatting (and makes the necessary changes in the currently existing files).
As suggested by @Ramy-Badr-Ahmed in #13, the new workflow uses
fprettify
. I could not force it to fail, if there are some changes necessary, so I used a fail if needs reformatting approach as in TheAlgorithms/Nim#19.Beside the indentation size being set to
4
, I used the default setting of thefprettify
. Please let me know if you prefer other settings.The failing part works logs for 8663d15.