-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Trie Data Structure with Case-Insensitive Feature and additional Test Cases #172
Merged
darwinz
merged 50 commits into
TheAlgorithms:master
from
Ramy-Badr-Ahmed:features/trie-extra
Oct 15, 2024
Merged
Enhanced Trie Data Structure with Case-Insensitive Feature and additional Test Cases #172
darwinz
merged 50 commits into
TheAlgorithms:master
from
Ramy-Badr-Ahmed:features/trie-extra
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brandon Johnson <[email protected]>
Co-authored-by: Brandon Johnson <[email protected]>
Co-authored-by: Brandon Johnson <[email protected]>
Co-authored-by: Brandon Johnson <[email protected]>
Co-authored-by: Brandon Johnson <[email protected]>
Co-authored-by: Brandon Johnson <[email protected]>
…ray updates reflections
…validArgumentException)
, TheAlgorithms#163, TheAlgorithms#166. Implemented Segment Tree Data Structure.
, TheAlgorithms#163, TheAlgorithms#166. Implemented Segment Tree Data Structure.
Co-authored-by: Brandon Johnson <[email protected]>
…e Trie implementation. Added corresponding unit testing.
Ramy-Badr-Ahmed
commented
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
darwinz
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements, and adding additional test cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to my #162:
Implemented case-insensitive handling in the
Trie
andTrieNode
classes, normalizing characters to lowercase during insertion, search, and deletion. This allows for consistent behavior regardless of letter casing.Enhanced the functionality and coverage of the Trie tests with additional edge cases:
insert()
with mixed-case words, special characters, and long strings.delete()
with mixed-case words and special characters.startsWith
with mixed-case inputs.getRoot()
before and after Trie population.This includes validating correct retrieval of the root node, validates it as an instance of
TrieNode
, and initially has no children.Tests the root node after inserting multiple words, verifying it has the expected children.
Added docblocks to each test method.
Reference
Data Structures and Algorithms in C++, 2nd Edition