Replaced InputText for the script component with a Combo (dropdown) #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lists all classes in ScriptEngine::GetEntityClasses - Effectively removes the need to change for an existing class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
While giving feedback when a class does not exist in the assembly, the input text doesn't what classes are available. Replacing this with a dropdown menu (ImGui::Combo / BeginCombo) removes this handicap, while also removing the check for an existing class, since this always will exist.
Nothing has been changed to the "Fields" part of the code, but the alignment and the ScriptClassExists check. The alignment causes an annoying unclear overview of the commit.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:
Proposed fix
Described in "Describe the issue"
Additional context
Only tested on Windows x64 with the latest master branch. (f8f8e30)