Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the typing package is installed only if needed (python < 3.5) #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WuShell
Copy link

@WuShell WuShell commented Dec 21, 2021

This prevents problems when installing cortex4py in recent python versions, where typing is installed as an external package, while there is a typing module included in the stdlib.

The external package then "shadows" the stdlib module, breaking other packages that use/rely on typing (when using cortex4py in a project with more dependencies)

I've used the suggested "incantation" to set up typing as a required dependency from the project site, here:

https://pypi.org/project/typing/

"For package maintainers, it is preferred to use typing;python_version<"3.5" if your package requires it to support earlier Python versions. This will avoid shadowing the stdlib typing module when your package is installed via pip install -t . on Python 3.5 or later."

Tested locally with python 3.7, 3.8 and 3.9

WuShell and others added 2 commits December 21, 2021 10:37
This prevents problems when installing cortex4py in recent python versions,
where typing is installed as an external package, while there is a typing
module included in the stdlib.

The external package then "shadows" the stdlib module, breaking other packages
that use/rely on typing (when using cortex4py in a project with more
dependencies)
@sinnwise
Copy link

sinnwise commented Aug 4, 2023

Hey, just wanted to bump this one if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants