-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert notification API #1202
Alert notification API #1202
Conversation
I think this PR should either go also to a feature branch or be held until the feature is complete and this PR covers the full functionality. |
I agree, left it as a draft with the intention of only merging it when the PR referenced goes into a release. Will do the same process as what is done on enterprise, change the target to a feature branch. |
42a473b
to
dee842c
Compare
With the previous topic more defined, I'll make this PR ready for review after the |
* doc: Update TTS Plans info * fixup! doc: Update TTS Plans info * fixup! doc: Update TTS Plans info * doc: Add downgrading plan info
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
e2ed11c
to
bcd8e27
Compare
@nejraselimovic could you give me a hand with an error I'm having on these changes? After changing Full error example:
|
* doc: Add v3.28.0 release docs * doc: Add new services to IS API docs
|
bcd8e27
to
9ea335f
Compare
@nejraselimovic thanks, missed this somehow and was a bit lost. |
9ea335f
to
b524299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it looks good, docs are building correctly, but I suggest you wait for another reviewers' approval just in case I'm missing something
Bumps [golang.org/x/image](https://github.com/golang/image) from 0.7.0 to 0.10.0. - [Commits](golang/image@v0.7.0...v0.10.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think some of the changes here are part of #1206 , which wasn't available when this branch was created. I suggest rebasing on top of master
both the feature branch and this branch.
* doc: Use cards in sub sections * doc: Move best practices * doc: Expand concepts * doc: Move models to a sub section * doc: Add configuration content * doc: Restructure adding devices * doc: Recreate adding devices * doc: Add other sections * doc: Update aliases * doc: Update introductory passage * doc: Update guide
b524299
to
cf93dc0
Compare
* doc: Update TTS Plans info (#1190) * doc: Update TTS Plans info * fixup! doc: Update TTS Plans info * fixup! doc: Update TTS Plans info * doc: Add downgrading plan info * doc: Update redirects (#1204) * build(deps): bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#1203) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * doc: Add v3.28.0 release docs (#1206) * doc: Add v3.28.0 release docs * doc: Add new services to IS API docs * build(deps): bump golang.org/x/image from 0.7.0 to 0.10.0 (#1207) Bumps [golang.org/x/image](https://github.com/golang/image) from 0.7.0 to 0.10.0. - [Commits](golang/image@v0.7.0...v0.10.0) --- updated-dependencies: - dependency-name: golang.org/x/image dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * doc: Subscription and billing mgmt FAQ update (#1211) * Restructure and update `devices` section (#1210) * doc: Use cards in sub sections * doc: Move best practices * doc: Expand concepts * doc: Move models to a sub section * doc: Add configuration content * doc: Restructure adding devices * doc: Recreate adding devices * doc: Add other sections * doc: Update aliases * doc: Update introductory passage * doc: Update guide * doc: Add receiver methods to identity_server api * doc: Add profile methods to identity_server api * doc: Add alertNotificationProfileIdentifiers to gateway api * doc: Add TTES's hugo generated docs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Nejra Selimović <[email protected]> Co-authored-by: Krishna Iyer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
References https://github.com/TheThingsIndustries/lorawan-stack/pull/3911
References https://github.com/TheThingsIndustries/product-management/issues/4
Introduces the documentation of Alert Notification API present on IS.
Screenshots
screenshots
Gateway.md update
IS API
profile CLI
Receivers CLI
Changes
AlertNotificationProfileIdentifiers
message to gateway's API section.ttn-lw-cli.json
to include new experimental CLI commands on the command line interface documentation section.Notes for Reviewers
Checklist
make server
, posted screenshots, verified external links. Test withHUGO_PARAMS_SEARCH_ENABLED=true
if style changes will affect the search bar.new-in-version
shortcode, according to the guidelines in CONTRIBUTING.