Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to gateways #1260

Merged
merged 13 commits into from
Feb 15, 2024

Conversation

LDannijs
Copy link
Contributor

@LDannijs LDannijs commented Feb 1, 2024

Summary

Add metadata to the gateway docs for use in the Partner Portal, Issue #1259

Changes

  • Add vendor and image to the metadata/front matter
  • Replace some low quality/missing images of gateways
  • remove duplicate Lorix UDP file.

Notes for Reviewers

@benolayinka

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@LDannijs LDannijs marked this pull request as draft February 2, 2024 10:59
@LDannijs
Copy link
Contributor Author

LDannijs commented Feb 2, 2024

  • Added vendor_page, ip_rating and backhaul type to frontmatter
  • Split up the docs for Milesight to allow specs to differentiate.

@LDannijs LDannijs marked this pull request as ready for review February 5, 2024 15:01
@johanstokking
Copy link
Member

Please triage assignee, milestone. Who's the main reviewer, Ben?

@LDannijs
Copy link
Contributor Author

LDannijs commented Feb 6, 2024

I would say Ben is yes. Also i do not have permissions for adding labels, milestones, etc.

@johanstokking johanstokking added this to the 2024 Q1 milestone Feb 6, 2024
aliases: [/gateways/cotx/x3]
image: [X3_1.png]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes to this image caused the next image to go left and it is no longer centered:

image

Can you pls fix this since all images below are centered

@@ -1,6 +1,6 @@
---
title: "MultiTech Conduit mLinux"
description: ""
description: "The MultiTech MultiConnect® Conduit™ is a configurable, scalable cellular communications gateway for industrial IoT applications."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other fields that you put for other gateways?

@benolayinka benolayinka merged commit 49b70fb into TheThingsIndustries:master Feb 15, 2024
1 check passed
@LDannijs LDannijs deleted the gateway-metadata branch March 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants