-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.33.0 documentation #1395
Conversation
We're missing the definitions for some messages. The ERROR Referenced type not rendered: "EmailNotificationPreferences" in page ".../lorawan-stack-docs/doc/content/api/reference/grpc/user.md:205:1"
ERROR Referenced type not rendered: "UserConsolePreferences.Tutorials" in page ".../lorawan-stack-docs/doc/content/api/reference/grpc/user.md:205:1" edit: Solved |
154a3f2
to
9c616a6
Compare
@@ -8,6 +8,8 @@ All meaningful changes to templates are documented in this file. | |||
|
|||
## Unreleased | |||
|
|||
## 3.32.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct, but I don't know why it wasn't added with v3.32.3
https://github.com/TheThingsIndustries/lorawan-stack-aws/blob/v3.33/UPGRADING.md#3323
Unless it's incorrect in lw-stack-aws
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are releasing documentation for v3.33.0
and the latest change here says it's for v3.32.3
and that doesn't seem incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the process the reason for this incorrectness in this release and the previous release is the fact that this PR Release v3.33.0 is not merged, which is the trigger to AWS templates release action.
Turns out that's the reason why tag release and docs release wasn't done in parallel -> docs release needs this PR to be merged already and AWS release finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 1199c62 to match UPGRADING.md
Summary
Release 3.33.0 documentation.
Automatic Changes
Manual Changes
Checklist for Reviewers