Changed some typo's and eddit parameters (#839)

* Add Vendor AccuWatch and Voltage Sensor device * Changed Parameters, and adjusted descriptions * Fixed Yaml Styling --------- Co-authored-by: Jaime Trinidad <[email protected]>
TheThingsNetwork · Nov 14, 2024 · be74ce9 · be74ce9
1 parent 0e1fc8a
commit be74ce9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 58 deletions.
diff --git a/vendor/accuwatch/3chbatteryvoltagesensor.yaml b/vendor/accuwatch/3chbatteryvoltagesensor.yaml
@@ -1,12 +1,10 @@
-name: LoRaWAN Voltage Sensor # Device name can not contain the vendor name
-description: 3 Channel Battery Volrage Sensor # Description of the device
+name: LoraWan 3ch Voltage Sensor # Device name can not contain the vendor name
+description: This custom-designed 3-Channel Battery Voltage Sensor is engineered to monitor the voltage of up to three separate batteries with a shared ground connection, making it ideal for applications where multiple batteries need simultaneous tracking. Constructed with an IP67-rated waterproof enclosure, it is built to withstand harsh environments, including marine and outdoor applications, where water and dust resistance are crucial.
 
 # Hardware versions (optional, use when you have revisions)
 hardwareVersions:
   - version: '1.0'
     numeric: 1
-  - version: '1.0-rev-A'
-    numeric: 2
 
 # Firmware versions (at least one is mandatory)
 firmwareVersions:
@@ -17,23 +15,15 @@ firmwareVersions:
     hardwareVersions:
       - '1.0'
 
-    # Firmware features (optional)
-    # Valid values are: remote rejoin (trigger a join from the application layer), transmission interval (configure how
-    # often he device sends a message).
-    # features:
-    #  - remote rejoin
-    #  - transmission interval
-
     # LoRaWAN Device Profiles per region
     # Supported regions are EU863-870, US902-928, AU915-928, AS923, CN779-787, EU433, CN470-510, KR920-923, IN865-867,
-    # RU864-870
     profiles:
       EU863-870:
         # Optional identifier of the vendor of the profile. When you specify the vendorID, the profile is loaded from
         # the vendorID's folder. This allows you to reuse profiles from module or LoRaWAN end device stack vendors.
         # If vendorID is empty, the current vendor ID is used. In this example, the vendorID is the current vendor ID,
         # which is verbose.
-        vendorID:
+        vendorID: accuwatch
         # Identifier of the profile (lowercase, alphanumeric with dashes, max 36 characters)
         id: 3chbatteryvoltagesensor-profile
         lorawanCertified: true
@@ -59,10 +49,6 @@ sensors:
 additionalRadios:
   - wifi
 
-# Bridge interfaces (optional)
-# Valid values are: modbus, m-bus, can bus, rs-485, sdi-12, analog, ethernet.
-# bridgeInterfaces:
-
 # Dimensions in mm (optional)
 # Use width, height, length and/or diameter
 dimensions:
@@ -79,35 +65,34 @@ weight: 190
 #   type: AA
 
 # # Operating conditions (optional)
-# operatingConditions:
-#   # Temperature (Celsius)
-#   temperature:
-#     min: -30
-#     max: 85
-#   # Relative humidity (fraction of 1)
-#   relativeHumidity:
-#     min: 0
-#     max: 0.97
+#  operatingConditions:
+#    # Temperature (Celsius)
+#    temperature:
+#      min: -30
+#      max: 85
+#    # Relative humidity (fraction of 1)
+#    relativeHumidity:
+#      min: 0
+#      max: 0.97
 
 # IP rating (optional)
 ipCode: IP67
 
 # Key provisioning (optional)
 # Valid values are: custom (user can configure keys), join server and manifest.
 keyProvisioning:
-  #  - custom
   - join server
 
 # Key programming (optional)
 # Valid values are: bluetooth, nfc, wifi, ethernet (via a webpage), serial (when the user has a serial interface to set the keys)
 # and firmware (when the user should change the firmware to set the keys).
-#keyProgramming:
+# keyProgramming:
 #  - serial
 #  - firmware
 
 # Key security (optional)
 # Valid values are: none, read protected and secure element.
-#keySecurity: none
+keySecurity: read protected
 
 # Firmware programming (optional)
 # Valid values are: serial (when the user has a serial interface to update the firmware), ethernet, fuota lorawan (when the device
@@ -117,27 +102,19 @@ firmwareProgramming:
   - fuota lorawan
 
 # Product and data sheet URLs (optional)
-# productURL: https://accuwatch.nl/LoRaWAN-voltage-sensor
+productURL: https://accuwatch.nl/LoRaWAN-voltage-sensor
 # dataSheetURL: https://accuwatch.nl/LoRaWAN-voltage-sensor/datasheet.pdf
 # Link to simple, easy onboarding instructions for the device (optional).
 # Please do not use this for marketing or overly technical documents like a data sheet.
 # onboardingGuideURL: https://www.thethingsindustries.com/docs/devices/models/windsensor
 
 # Commercial information
-# resellerURLs:
-#   - name: 'Reseller 1'
-#     region: # valid regions are: Argentina, Australia, Brazil, Canada, China, European Union, India, Indonesia.
-#       # Japan, Mexico, Russia, Saudi Arabia, South Africa, South Korea, Turkey, United States, Other
-#       - European Union
-#     url: https://accuwatch.nl/reseller1
-#   - name: 'Reseller 2'
-#     region:
-#       - United States
-#       - Canada
-#     url: https://accuwatch.nl/reseller2
-# msrp:
-#   EUR: 90
-#   USD: 120
+resellerURLs:
+  - name: 'AccuWatch'
+    region: # valid regions are: Argentina, Australia, Brazil, Canada, China, European Union, India, Indonesia.
+      #       # Japan, Mexico, Russia, Saudi Arabia, South Africa, South Korea, Turkey, United States, Other
+      - European Union
+    url: https://accuwatch.nl/
 
 # Photos
 photos:

diff --git a/vendor/accuwatch/index.yaml b/vendor/accuwatch/index.yaml
@@ -1,17 +1,3 @@
-# This example contains just one end device: windsensor. It is referenced here in the index.
-
 endDevices:
   # Unique identifier of the end device (lowercase, alphanumeric with dashes, max 36 characters)
   - 3chbatteryvoltagesensor # look in 3chbatteryvoltagesensor.yaml for the end device definition
-
-# The profileIDs is a distinct value for every unique profile listed in the vendor's folder.
-# This value can be freely issued by the vendor and is also used on the QR code for LoRaWAN devices, see
-# https://lora-alliance.org/wp-content/uploads/2020/11/TR005_LoRaWAN_Device_Identification_QR_Codes.pdf#page=8
-# It can either be a combo of device ID + hardware version + firmware version + region, or profile ID + codec ID
-# NOTE: The profileIDs is different from the vendorID.
-profileIDs:
-  '1':
-    endDeviceID: '3chbatteryvoltagesensor'
-    firmwareVersion: '1.0'
-    hardwareVersion: '1.0'
-    region: 'EU863-870'