vendorProfileId

[Jaime-Trinidad]

Summary

Add unique vendorProfileId to The Things Product and The Things Industries devices #405

Changes

• Add a unique vendorProfileId in each profile file, without repeating the Id
• The Id is a random number

Notes for Reviewers

...

Release Notes

• ...

[KrishnaIyer]

@johanstokking: We are free to assign the vendorProfileID right? Should we follow some internal convention?
Just use linear numbers for each new profile?

[johanstokking]

Indeed we're free to assign them. They're 16 bit. This is already enforced by the JSON schema validator.

I would indeed make them increasing and not jump to 868.

[Jaime-Trinidad]

we can establish that 'vendorProfileId' should be filled linear instead of freely choice, what do you think?

[KrishnaIyer]

we can establish that 'vendorProfileId' should be filled linear instead of freely choice, what do you think?

Ideally users can fill any valid value and we only check that it is unique for a given vendor. But if that's too complicated to validate, then I guess it's ok to make it linear.

[johanstokking]

We can make this part of validation in CI.

Can you file an issue @Jaime-Trinidad ?

[Jaime-Trinidad]

Yes I file an issue