Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lualtek swsi device #607

Closed
wants to merge 14 commits into from
Closed

Added Lualtek swsi device #607

wants to merge 14 commits into from

Conversation

LasaleFamine
Copy link

Summary

Adding new vendor device by Lualtek into the device repository

Changes

  • added vendor/lualtek
  • modified vendor/index.yml

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@LasaleFamine
Copy link
Author

Hello @Jaime-Trinidad is there some sort of ETA that we should wait every time we open a PR? Because I have other devices to add and I want to understand if it's better to open a PR with everything inside (although it would be more difficult to review...). Thanks!

@Jaime-Trinidad
Copy link
Contributor

hey @LasaleFamine thanks for the update, please review the error that your files gives in the class C, and run validation commands again

@LasaleFamine
Copy link
Author

@Jaime-Trinidad I had a problem on the validate command that didn't run properly in local. Now it should be ok. Sorry for the inconvenient.

@LasaleFamine
Copy link
Author

@Jaime-Trinidad sorry for bothering, just want to test if this works so I can open a new PR with other devices. Are there any news? Thanks!

@Jaime-Trinidad
Copy link
Contributor

Hi @LasaleFamine now it looks it runs properly, I can't update so, can you update it, I will wait you to do it, so I can merge it, thanks

@LasaleFamine
Copy link
Author

@Jaime-Trinidad done!

@Jaime-Trinidad
Copy link
Contributor

Hi @LasaleFamine there is an error in the validation, can you check the codec file:

lualtek: lualtek-swsi: EU863-870: payload codec lualtek-swsi-codec invalid Error: Command failed: bin/runscript -codec-path "./vendor/lualtek/lualtek-swsi.js" -routine encodeDownlink -input '{"data":{"switchValue":0}}' 2023/06/07 09:41:33 Marshal output: json: unsupported value: NaN

@LasaleFamine
Copy link
Author

Hi @Jaime-Trinidad it's been a bit frustrating since locally I don't see any error when running the validation. Also seems like the validation script just spawns a lot of processes that sometimes crushes my Mac. I think I will remove that part from the codec directly since I cannot test it with ease.

@LasaleFamine
Copy link
Author

Hello @Jaime-Trinidad are there any news for this one?

@LDannijs LDannijs mentioned this pull request Dec 12, 2023
@Jaime-Trinidad
Copy link
Contributor

Hi @LasaleFamine we replicated the PR and we already merge it, it will be in the next release of TTS, I will close this PR

@LasaleFamine
Copy link
Author

@Jaime-Trinidad that's awesome! Sorry for not being able to fix it as per CI.

I will try to emulate yours for new devices. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants