Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elspina vendor and em-elst01 device #668

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

BrittaHhm
Copy link
Contributor

Summary

Add vendor elspina and device em-elst01

Changes

  • ...
  • ...

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023

CLA assistant check
All committers have signed the CLA.

@BrittaHhm
Copy link
Contributor Author

@Jaime-Trinidad - Could you please tell us what we need to fix so the pull request can be closed?

@Jaime-Trinidad
Copy link
Contributor

Hi @BrittaHhm can you review your decoder and codec file, name the functiondecodeUplinkand check the output in codec example

@Jaime-Trinidad
Copy link
Contributor

Hi @BrittaHhm there is still an error in em-elst01-codec.yaml the output of the second example does not fit, you need to check your decoder .js file so it is well handled:

./bin/runscript -codec-path "vendor/elspina/em-elst01.js" -routine decodeUplink -input '{"fPort":42,"bytes":["0x0D", "0x48", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0x00", "0xFF", "0xF5", "0xFF", "0xC6", "0x03", "0x9D", "0x01", "0x00"]}'

Output
{"ALARM":"0x00","Bat":3.4,"LDOD":0,"TNOMD":0,"TODE":0,"X":"-0.10","Y":"-0.57","Z":"9.25","status":0,"temp_ds":"25.6"}
expected output = errors: unknown Fport

@Jaime-Trinidad Jaime-Trinidad merged commit 89b02e6 into TheThingsNetwork:master Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants