-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing sensors and add device types #772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to update Netvox, Radio bridge and Tektelic anyway :) |
johanstokking
approved these changes
Apr 19, 2024
Jaime-Trinidad
approved these changes
Apr 23, 2024
Jaime-Trinidad
approved these changes
May 2, 2024
Jaime-Trinidad
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looked through the devices csv to note which devices are missing sensors. Was able to add it for a lot but Netvox, Radio Bridge and Tektelic have too many to manually change. Also added
devicetype
to compensate for devices with no sensors. Closes #769Changes
devicetype
to the schema to identify what type of device it isdevicetype
to be able to filter for them.devicetype
to the csv scriptThe-box development
andGrinn
Notes for Reviewers
@Jaime-Trinidad lets discuss if this is correct and if there are things we're missing.