Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Senzemo Folder #813

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Edit Senzemo Folder #813

wants to merge 6 commits into from

Conversation

vzmvc
Copy link

@vzmvc vzmvc commented Aug 6, 2024

Summary

Updated our data with new webpage links, new vendors and added new sensors.

Changes

  • Changed URLs to products and datasheets
  • Added new sensors (STO10, STP40, STF40, SSM40)

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2024

CLA assistant check
All committers have signed the CLA.

@Jaime-Trinidad
Copy link
Contributor

Hi @vzmvc there are some changes to do, in your resellers regions please put European Union in all UK, Germany, Austria, for the moment that is the only acceptable value. Also in the sensors please use the sensors that are on the list, if the sensors are not in the list please put it commented to the validation pass.

@LDannijs
Copy link
Contributor

LDannijs commented Sep 9, 2024

To add to this, please look at the example file. It will show in the comments which values are valid.

# Sensors that this device features (optional)
# Valid values are:
# 4-20 ma, accelerometer, altitude, analog input, auxiliary, barometer, battery, button, bvoc, co, co2, conductivity, current, digital input,
# digital output, dissolved oxygen, distance, dust, energy, gps, gyroscope, h2s, hall effect, humidity, iaq, infrared, leaf wetness, level,
# light, lightning, link, magnetometer, moisture, motion, nfc, no, no2, o3, occupancy, optical meter, particulate matter, ph, pir,
# pm2.5, pm10, potentiometer, power, precipitation, pressure, proximity, pulse count, pulse frequency, radar, rainfall, reed switch, rssi,
# sap flow, smart valve, smoke, snr, so2, solar radiation, sound, strain, surface temperature, switch, temperature, tilt, time, turbidity,
# tvoc, uv, vapor pressure, velocity, vibration, voltage, water potential, water, weight, wifi ssid, wind direction, wind speed.

region: # valid regions are: Argentina, Australia, Brazil, Canada, China, European Union, India, Indonesia.
# Japan, Mexico, Russia, Saudi Arabia, South Africa, South Korea, Turkey, United States, United Kingdom, Other

Note we just added a PR for adding the United Kingdom to the list of valid values so make sure that you have updated your branch.

@Jaime-Trinidad
Copy link
Contributor

Hi @vzmvc please check the files, there are errors in the images extensions, in sensor arrays, if you are not adding sensors for the moment, please comment #sensors:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants