Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted PCR2 from Vendor Parametric #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akoschak
Copy link

@akoschak akoschak commented Oct 6, 2024

Summary

...

Changes

Deleted PCR2 data and index.yalm

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Jaime-Trinidad
Copy link
Contributor

Hi @akoschak why you delete the device? if the device is out of the market now, probably are users with this device, if we delete it they will stop working on TTS and will cause problems.

@akoschak
Copy link
Author

akoschak commented Oct 10, 2024 via email

@Jaime-Trinidad
Copy link
Contributor

@akoschak totally understand, but still not deleting the device will be the best, as we don't know how many users are working with it, the issues will come up directly to us, it will be better if you update the .yaml in description and tell them the device is not supported by Parametric and now is supported by PMX system.

@Jaime-Trinidad
Copy link
Contributor

Hi @akoschak any comment on my last message?

@sjackle
Copy link

sjackle commented Nov 21, 2024

I'm the new maintainer of the PCR2 device.
Could we set it to something like "Deprecated"?

The profile is wrong and does not reflect the firmware anymore. So we have a lot of support.

@Jaime-Trinidad
Copy link
Contributor

Hi @sjackle on your side or with the files here? is there any update to do?

@sjackle
Copy link

sjackle commented Dec 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants