Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI usage of secrets #6156

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix CI usage of secrets #6156

merged 1 commit into from
Apr 14, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Apr 14, 2023

Summary

References github/docs#6861
References #6154 (comment)

Apparently secrets are not available as part of if, so we need to inject the secret (which is not really secret, the region is not that special) as an environment variable and compare that.

Changes

  • Inject the AWS_REGION as an environment variable, and then use it for the comparison.

Testing

CI.

Regressions

This fixes a regression in itself.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.25.2 milestone Apr 14, 2023
@adriansmares adriansmares self-assigned this Apr 14, 2023
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Apr 14, 2023
@adriansmares adriansmares force-pushed the fix/skip-login-on-fork-v2 branch from bdf2838 to 4fe8fa9 Compare April 14, 2023 14:24
@github-actions github-actions bot removed the c/identity server This is related to the Identity Server label Apr 14, 2023
@adriansmares adriansmares changed the title CI testing Fix CI usage of secrets Apr 14, 2023
@adriansmares adriansmares marked this pull request as ready for review April 14, 2023 14:26
@adriansmares adriansmares merged commit bcbda8a into v3.25 Apr 14, 2023
@adriansmares adriansmares deleted the fix/skip-login-on-fork-v2 branch April 14, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants