Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate whether the frequency plan is applicable to gateways #7235

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Aug 13, 2024

Summary

References: TheThingsNetwork/lorawan-frequency-plans#41

Extended the FrequencyPlanDescription struct with Gateways field to indicate that the frequency plan is relevant for a gateway.
Added GatewaysOnly flag to the ListFrequencyPlans RPC to filter out non-gateway related plans.

Changes

  • Extended the FrequencyPlanDescription struct with Gateways field to indicate that the frequency plan is relevant for a gateway
  • Added GatewaysOnly flag to the ListFrequencyPlans RPC to filter out non-gateway related plans
  • Added gateways-only flag to the list-frequency-plans CLI command to filter out non-gateway related plans

Testing

Steps
  • Use the gateways-only flag on the list-frequency-plans CLI command to filter out non-gateway related frequency plans
$ go run ./cmd/ttn-lw-cli gateways list-frequency-plans --gateways-only
Results
  • It shows only the frequency plans where the gateways filed is true
Regressions
  • No regression

Notes for Reviewers

  • No notes

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi requested a review from a team as a code owner August 13, 2024 15:22
@halimi halimi changed the title util: Add Gateways field to the FrequencyPlan Indicate whether the frequency plan is applicable to gateways Aug 13, 2024
@halimi halimi self-assigned this Aug 13, 2024
@halimi halimi added this to the v3.32.0 milestone Aug 13, 2024
@halimi halimi force-pushed the feature/filter-frequency-plans branch from e6eb765 to d690f6a Compare August 14, 2024 08:57
@KrishnaIyer KrishnaIyer modified the milestones: v3.32.0, v3.32.1 Aug 14, 2024
@KrishnaIyer
Copy link
Member

Today is the merge deadline but I won't have time to review this unfortunately. Moving the milestone.

pkg/frequencyplans/frequencyplans.go Outdated Show resolved Hide resolved
pkg/frequencyplans/frequencyplans.go Outdated Show resolved Hide resolved
@halimi halimi requested a review from a team as a code owner August 30, 2024 12:47
@github-actions github-actions bot added the ui/cli This is related to ttn-lw-cli label Aug 30, 2024
@halimi halimi force-pushed the feature/filter-frequency-plans branch from 2097d13 to b7a44d9 Compare August 30, 2024 13:57
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

api/ttn/lorawan/v3/configuration_services.proto Outdated Show resolved Hide resolved
@halimi halimi merged commit 5caad01 into v3.32 Sep 5, 2024
15 of 16 checks passed
@halimi halimi deleted the feature/filter-frequency-plans branch September 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/cli This is related to ttn-lw-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants