-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LoRaWAN 1.2.0 default cipher suite #7248
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
August 19, 2024 11:10
f371a4f
to
37786cf
Compare
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
August 20, 2024 12:44
a4491f9
to
298f078
Compare
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
August 21, 2024 15:43
b722404
to
3498d67
Compare
halimi
changed the title
Support LoRaWAN 1.2.0 DOWNLINK_MIC_A_SCHEME
Support LoRaWAN 1.2.0 default cipher suite
Aug 21, 2024
github-actions
bot
added
the
c/network server
This is related to the Network Server
label
Aug 22, 2024
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
August 28, 2024 09:26
62d74b5
to
664683f
Compare
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
August 28, 2024 13:06
4cf915c
to
d5ab632
Compare
github-actions
bot
added
the
c/gateway server
This is related to the Gateway Server
label
Sep 12, 2024
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
September 12, 2024 14:26
53fe44b
to
11483ce
Compare
halimi
force-pushed
the
feature/lorawan-1.2-encryption
branch
from
September 23, 2024 09:43
6db97d6
to
c1f4e47
Compare
@halimi, as discussed, let's close this PR but leave the branch. |
I'm closing this issue now because of the LoRaWAN standard version 1.2.0 is not finalized yet and we are expecting some major change will come. So for now, we put on hold the implementation and later we will continue with the new version of the standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/gateway server
This is related to the Gateway Server
c/join server
This is related to the Join Server
c/network server
This is related to the Network Server
security
This is important for security
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References: https://github.com/TheThingsIndustries/lorawan-stack/issues/4313
LoRaWAN 1.2.0 standard supports different cipher suites. Each cipher suite defines a set of encryption and MIC calculation functions. There is a new MIC calculation for downlink, called DOWNLINK_MIC_A_SCHEME. There are also two new MAC commands DevMobilityInd/DevMobilityResp and NegotiationInd/NegotiationConf. Besides that there is a new field in ResetInd/ResetConf and RekeyInd/RekeyConf to support the cipher suites.
Changes
JoinRequest
for LoRaWAN 1.2 devicesRekeyInd
/RekeyConf
MAC command with cipher IDResetInd
/ResetConf
MAC command with cipher IDNegotiationInd
andNegotiationConf
MAC commandDevMobilityInd
andDevMobilityResp
MAC commandTesting
Steps
JoinRequest
for LoRaWAN 1.2 devicesJoinRequest
Results
JoinRequest
for LoRaWAN 1.2 devicesJoinRequest
Regressions
...
Notes for Reviewers
...
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.