Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TX channel configuration in dynamic channel regions #7286

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

johanstokking
Copy link
Member

@johanstokking johanstokking commented Sep 9, 2024

Summary

This fixes default and custom RX2 parameters as well as Class C in dynamic channel plan regions.

Changes

  • Update The Things Industries gateway protocol API with support for TX channel configuration. This allows for configuring TX frequency and bandwidth if it deviates from the frequency plan's downlink channels
  • Configure default RX2 parameters as TX channel to save bandwidth
  • Extend GS frontend test bench with a custom frequency and fix Class C parameters

Testing

Steps
  1. Register a gateway using The Things Industries gateway protocol
  2. Register an EU868 end device with class C enabled
  3. Configure the end device with data rate 6 (SF7, 250 KHz) for RX2 and enable class C
  4. Let the end device join
  5. Send downlink messages
  6. Repeat step 3 with standard data rate for RX2 (any SF at 125 KHz)
Results

Downlink messages should arrive.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

This fixes default and custom RX2 parameters as well as Class C in dynamic channel plan regions.
@johanstokking johanstokking requested review from a team as code owners September 9, 2024 12:43
@johanstokking johanstokking added this to the v3.32.1 milestone Sep 9, 2024
@johanstokking johanstokking self-assigned this Sep 9, 2024
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file ui/web This is related to a web interface tooling Development tooling labels Sep 9, 2024
@johanstokking johanstokking merged commit c35471d into v3.32 Sep 9, 2024
15 of 16 checks passed
@johanstokking johanstokking deleted the fix/ttigw-rx2 branch September 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants