-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset wifi profile from managed gateway connection settings #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/gateway conf server
This is related to the Gateway Configuration Server
ui/web
This is related to a web interface
labels
Sep 20, 2024
PavelJankoski
changed the title
Remove wifi profile from managed gateway connection settings
Unset wifi profile from managed gateway connection settings
Sep 20, 2024
I'm getting: {
"code": 3,
"message": "error:pkg/rpcmiddleware/validator:field_mask_paths (forbidden path(s) in field mask)",
"details": [
{
"@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
"namespace": "pkg/rpcmiddleware/validator",
"name": "field_mask_paths",
"message_format": "forbidden path(s) in field mask",
"attributes": {
"forbidden_paths": [
"_enable_wifi_connection"
]
},
"correlation_id": "26750bff9bb54e2493c1dd7699965790",
"code": 3
}
]
} The request payload is:
|
johanstokking
approved these changes
Sep 20, 2024
johanstokking
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm getting this error:
{
"code": 3,
"message": "error:pkg/gatewayconfigurationserver/managed:no_ssid (no SSID set)",
"details": [
{
"@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
"namespace": "pkg/gatewayconfigurationserver/managed",
"name": "no_ssid",
"message_format": "no SSID set",
"correlation_id": "4d087545d1b74dadb2ede346161e0232",
"code": 3
}
]
}
The request is:
POST
https://localhost:8885/api/v3/gcs/gateways/profiles/wifi/users/admin
{"profile":{"profile_name":"1726834538246","shared":false}}
So it tries to set a profile still.
johanstokking
approved these changes
Sep 20, 2024
ryaplots
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/gateway conf server
This is related to the Gateway Configuration Server
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unset wifi profile from managed gateway connection settings
Changes
Testing
Steps
Results
Unchecking the 'Enable WiFi connection' checkbox should unset already assigned wifi profile.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.