Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset wifi profile from managed gateway connection settings #7315

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

PavelJankoski
Copy link
Contributor

@PavelJankoski PavelJankoski commented Sep 20, 2024

Summary

Unset wifi profile from managed gateway connection settings

Changes

  • Added checkbox 'Enable WiFi connection' in connection settings form.
  • Form validation changes and UI improvements.
  • Modified e2e tests.

Testing

Steps
  1. Login to console.
  2. Navigate to /gateways.
  3. Select managed gateway.
  4. Go to connection settings in the side navigation.
  5. Try to enable/disable wifi connection and check if it works.
Results

Unchecking the 'Enable WiFi connection' checkbox should unset already assigned wifi profile.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added this to the 2024 Q3 milestone Sep 20, 2024
@PavelJankoski PavelJankoski self-assigned this Sep 20, 2024
@PavelJankoski PavelJankoski requested review from a team as code owners September 20, 2024 09:42
@github-actions github-actions bot added c/gateway conf server This is related to the Gateway Configuration Server ui/web This is related to a web interface labels Sep 20, 2024
@PavelJankoski PavelJankoski changed the title Remove wifi profile from managed gateway connection settings Unset wifi profile from managed gateway connection settings Sep 20, 2024
@johanstokking
Copy link
Member

I'm getting:

{
  "code": 3,
  "message": "error:pkg/rpcmiddleware/validator:field_mask_paths (forbidden path(s) in field mask)",
  "details": [
    {
      "@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
      "namespace": "pkg/rpcmiddleware/validator",
      "name": "field_mask_paths",
      "message_format": "forbidden path(s) in field mask",
      "attributes": {
        "forbidden_paths": [
          "_enable_wifi_connection"
        ]
      },
      "correlation_id": "26750bff9bb54e2493c1dd7699965790",
      "code": 3
    }
  ]
}

The request payload is:

{"profile":{"shared":false,"_enable_wifi_connection":false},"field_mask":{"paths":["shared","network_interface_addresses","_enable_wifi_connection"]}}

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm getting this error:

{
  "code": 3,
  "message": "error:pkg/gatewayconfigurationserver/managed:no_ssid (no SSID set)",
  "details": [
    {
      "@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
      "namespace": "pkg/gatewayconfigurationserver/managed",
      "name": "no_ssid",
      "message_format": "no SSID set",
      "correlation_id": "4d087545d1b74dadb2ede346161e0232",
      "code": 3
    }
  ]
}

The request is:

POST
	https://localhost:8885/api/v3/gcs/gateways/profiles/wifi/users/admin
{"profile":{"profile_name":"1726834538246","shared":false}}

So it tries to set a profile still.

Screenshot 2024-09-20 at 14 20 26

@johanstokking johanstokking merged commit 94ea5fb into v3.32 Sep 20, 2024
15 checks passed
@johanstokking johanstokking deleted the fix/remove-wifi-profile branch September 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway conf server This is related to the Gateway Configuration Server ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants