Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device ID check for top devices in the app overview #7321

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

kschiffer
Copy link
Contributor

Summary

This quickfix PR addresses an issue that would lead to top devices from other applications being shown in the application overview.

Changes

  • Fix the app ID comparison

Notes for Reviewers

This has been reported by a community member and happens when two applications with a common prefix are visited. Due to the ID comparison running on startsWith this allows devices of applications that have a common start to be selected as well.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer requested a review from a team as a code owner October 3, 2024 14:05
@kschiffer kschiffer requested a review from ryaplots October 3, 2024 14:05
@kschiffer kschiffer self-assigned this Oct 3, 2024
@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console ui/web This is related to a web interface labels Oct 3, 2024
@kschiffer kschiffer added this to the v3.32.1 milestone Oct 3, 2024
@kschiffer kschiffer merged commit 5978c07 into v3.32 Oct 6, 2024
11 of 13 checks passed
@kschiffer kschiffer deleted the fix/top-devices-leak branch October 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants