Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add device attributes to ApplicationUp messages #7451

Open
wants to merge 3 commits into
base: v3.33
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
run:
skip-dirs:
- node_modules

linters:

Check warning on line 1 in .golangci.yml

View workflow job for this annotation

GitHub Actions / Check Mergeability

.golangci.yml has a conflict when merging TheThingsIndustries/lorawan-stack:v3.33.
disable-all: true
enable:
# Enabled by default:
Expand Down Expand Up @@ -113,3 +109,6 @@
- linters:
- paralleltest
text: 'does not use range value in test Run'
exclude-dirs:
- node_modules

10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,21 @@ For details about compatibility between different releases, see the **Commitment
- Add recvTime field to the decodeUplink input in payload formatters
- Add the latest battery percentage of the end device in the `ApplicationUplink` message.
- Add live data split view tutorial to the Console.
- Add end device attributes to ApplicationUp messages.
- Add the locations, version_ids, network_ids fields to the following ApplicationUp messages:
- ApplicationJoinAccept
- ApplicationDownlink
- ApplicationDownlinkFailed
- ApplicationInvalidatedDownlinks
- ApplicationServiceData
- Add Timeout and Cache fields in the EndDeviceMetadataStorageConfig of the AS.

### Changed

### Deprecated

- Deprecate the Location field (and its subfields) in the EndDeviceMetadataStorageConfig of AS.

### Removed

### Fixed
Expand Down
130 changes: 130 additions & 0 deletions api/ttn/lorawan/v3/api.md

Large diffs are not rendered by default.

124 changes: 124 additions & 0 deletions api/ttn/lorawan/v3/api.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -20326,6 +20326,28 @@
},
"confirmed_retry": {
"$ref": "#/definitions/ApplicationDownlinkConfirmedRetry"
},
"locations": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/lorawanv3Location"
},
"description": "End device location metadata, set by the Application Server while handling the message."
},
"version_ids": {
"$ref": "#/definitions/v3EndDeviceVersionIdentifiers",
"description": "End device version identifiers, set by the Application Server while handling the message."
},
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand All @@ -20337,6 +20359,28 @@
},
"error": {
"$ref": "#/definitions/v3ErrorDetails"
},
"locations": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/lorawanv3Location"
},
"description": "End device location metadata, set by the Application Server while handling the message."
},
"version_ids": {
"$ref": "#/definitions/v3EndDeviceVersionIdentifiers",
"description": "End device version identifiers, set by the Application Server while handling the message."
},
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down Expand Up @@ -20377,6 +20421,28 @@
"session_key_id": {
"type": "string",
"format": "byte"
},
"locations": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/lorawanv3Location"
},
"description": "End device location metadata, set by the Application Server while handling the message."
},
"version_ids": {
"$ref": "#/definitions/v3EndDeviceVersionIdentifiers",
"description": "End device version identifiers, set by the Application Server while handling the message."
},
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down Expand Up @@ -20408,6 +20474,28 @@
"type": "string",
"format": "date-time",
"description": "Server time when the Network Server received the message."
},
"locations": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/lorawanv3Location"
},
"description": "End device location metadata, set by the Application Server while handling the message."
},
"version_ids": {
"$ref": "#/definitions/v3EndDeviceVersionIdentifiers",
"description": "End device version identifiers, set by the Application Server while handling the message."
},
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down Expand Up @@ -20907,6 +20995,28 @@
},
"data": {
"type": "object"
},
"locations": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/lorawanv3Location"
},
"description": "End device location metadata, set by the Application Server while handling the message."
},
"version_ids": {
"$ref": "#/definitions/v3EndDeviceVersionIdentifiers",
"description": "End device version identifiers, set by the Application Server while handling the message."
},
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down Expand Up @@ -21072,6 +21182,13 @@
"last_battery_percentage": {
"$ref": "#/definitions/v3LastBatteryPercentage",
"description": "Last battery percentage of the end device.\nReceived via the DevStatus MAC command at last_dev_status_received_at or earlier.\nSet by the Network Server while handling the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down Expand Up @@ -21148,6 +21265,13 @@
"network_ids": {
"$ref": "#/definitions/v3NetworkIdentifiers",
"description": "Network identifiers, set by the Network Server that handles the message."
},
"attributes": {
"type": "object",
"additionalProperties": {
"type": "string"
},
"description": "Attributes for devices, set by the Application Server while handling the message."
}
}
},
Expand Down
Loading
Loading