Fix circular includes #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `donut.h` include from `format.h`. Separate out `DONUT_ERROR_*` macros to separate `errors.h` header file to satisfy `format.c`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a circular include where include/donut.h#L85 includes
format.hwhile include/format.h#L35 includesdonut.h. This could potentially cause issues where included symbols do not get defined.Since
format.conly usesdonut.hfor the error macros, they can be refactored out into a separateerrors.hfile which can be included separately informat.cwithout needing to include all ofdonut.h.The
DPRINTmacro has to be re-implemented because it is needed forformat.cbut is only defined indonut.handloader/loader.h. loader/loader.h#L101 also includesdonut.hso it cannot be used since this would result in another circular include.