Update FSEventStreamScheduleWithRunLoop to FSEventStreamSetDispatchQueue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 18, 2023 00:28
Remove unnecessary multithreading for MacOS Check if event file matches before calling seeSingleFileChanges()
CMakeLists.txt
Outdated
| @@ -41,4 +41,4 @@ if(BuildTests) | |||
| add_subdirectory(tests) | |||
| endif() | |||
|
|
|||
| # add_subdirectory(example) | |||
| add_subdirectory(example) | |||
There was a problem hiding this comment.
Can you hide this behind an option? just this breaks projects that use cmake fetchcontent_declare to import the client.
Something like:
FileWatch_Build_Example?
Thank you
|
Thank you very much, I will try to check this out in the coming days |
pinguin999
reviewed
Jan 20, 2023
| @@ -208,7 +208,7 @@ namespace filewatch { | |||
| return *this; | |||
| } | |||
|
|
|||
| // Const memeber varibles don't let me implent moves nicely, if moves are really wanted std::unique_ptr should be used and move that. | |||
| // Const member variables don't let me implement moves nicely, if moves are really wanted std::unique_ptr should be used and move that. | |||
| FileWatch<StringType>(FileWatch<StringType>&&) = delete; | |||
There was a problem hiding this comment.
Suggested change
| FileWatch<StringType>(FileWatch<StringType>&&) = delete; | |
| FileWatch(FileWatch<StringType>&&) = delete; |
SAURABHS1993
added a commit
to elphasecure/filewatch2
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dispatch_queue already handles multithreading, I've also removed our multithreading and synchronisation code.