Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add railways in city mode #21

Closed
wants to merge 3 commits into from

Conversation

JulesL2
Copy link
Contributor

@JulesL2 JulesL2 commented Sep 28, 2024

Description

  • Add the support for railways
  • Upgrade the merging algorithm to switch from a O(n^2) to O(n*log(n)) on average, this improvement was not needed before because rivers where small lists but it is needed for railways because lists are much larger and merging is required to create the sleepers for railways
  • Making rivers generation more robusts with more logs

Warning

Should be merged after the performance PR #19

Proof of Functionality

railways

@github-actions github-actions bot added the enhancement New feature or request label Sep 28, 2024
@JulesL2 JulesL2 changed the title feat: add railways feat: add railways in city mode Sep 29, 2024
@@ -18,3 +18,5 @@ ruff==0.4.6
textalloc==1.1.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work to manage to collect this data
However I find that roads and rivers alone are the perfect balance between too few and too much data, to still recognize the minimalist city's signature 🤔
I asked some friends who tend to agree with the fact that Railways aren't that recognizable and kind of pollute the whole minimalist design

Would you mind keeping your optim for the merge algorithm and the river improvment but discard the railway part ? 😕

It can be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants