Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airports #22

Closed
wants to merge 4 commits into from
Closed

Conversation

JulesL2
Copy link
Contributor

@JulesL2 JulesL2 commented Sep 28, 2024

Description

Work finished
That would be good to close : #9

  • Added a relation recursion option to reduce the time to process relations (download directly the first time instead of dowloading when needed)
  • Improved geometries handling in the overpass processing functions -> Important time reduction for large geoms
  • Improved also the hash table for closed geoms such as forests and rivers with a shuffle and consecutive segments update.
  • Added forest and airports
  • Improve logs

Warning

Merge after overpass speed up and railways as this PR rebase on railways

Proof of Functionality

airports_and_forests

@github-actions github-actions bot added the enhancement New feature or request label Sep 28, 2024
@JulesL2 JulesL2 force-pushed the JulesL2/forests branch 2 times, most recently from 0e1472e to 5da9f59 Compare September 29, 2024 08:51
@JulesL2 JulesL2 changed the title feat: add airports and forests feat: add airports and forests in city mode Sep 29, 2024
.devcontainer/requirements.txt Outdated Show resolved Hide resolved
.devcontainer/requirements.txt Outdated Show resolved Hide resolved
@JulesL2 JulesL2 force-pushed the JulesL2/forests branch 2 times, most recently from 56f8fb0 to 230e94d Compare October 4, 2024 19:15
@JulesL2
Copy link
Contributor Author

JulesL2 commented Oct 4, 2024

@ThomasParistech
To "match" more a google maps view, I have added the farmland with a different shade.
It gives this result

R4C_farmland

@JulesL2
Copy link
Contributor Author

JulesL2 commented Oct 7, 2024

@ThomasParistech
Don't you think that forest like this can be cool (there is also the linewith feat of PR #24 in the image)

R4C

@@ -29,6 +29,12 @@ class CityDrawingFigure(BaseDrawingFigure):
road_data: list[BaseDrawingData]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulesL2
Indeed I agree that the left map looks better (eventhough we still need to play a bit with the colors). Especially for small runs in the countryside 👌 😃
Ideally there will be an option in the GUI to choose what we're displaying

However, I'm still not convinced by the airport and the railways :/

image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulesL2
If we start adding airports, we'll need to add nuclear plants, schools, swimming pools.....
I'd rather keep it minimalist
your Geneva run will already look cool without the airport ;)

@JulesL2
Copy link
Contributor Author

JulesL2 commented Oct 10, 2024

For this run I like the airport :). Do you think there are improvements to make ?

20km_Geneve

@JulesL2 JulesL2 changed the title feat: add airports and forests in city mode feat: add airports Oct 15, 2024
@JulesL2 JulesL2 closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants