feat: add the possibility to switch from two lines layout to single one #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesL2
force-pushed
the
JulesL2/2lines_layout
branch
2 times, most recently
from
2a46044
to
ba6bd7b
Compare
JulesL2
force-pushed
the
JulesL2/2lines_layout
branch
2 times, most recently
from
9f6d5d8
to
9dbcc24
Compare
ThomasParistech
approved these changes
Nov 4, 2024
|
@ThomasParistech I fixed your comments. Ready to merge 🎈 |
JulesL2
force-pushed
the
JulesL2/2lines_layout
branch
from
080b2af
to
d502c4c
Compare
|
Need python 3.11 to use the Self variable that you have suggest. |
| from dataclasses import dataclass | ||
| from dataclasses import fields | ||
| from typing import ClassVar | ||
| from typing import Self |
There was a problem hiding this comment.
Suggested change
| from typing import Self | |
| from typing_extensions import Self |
There was a problem hiding this comment.
@ThomasParistech Don't you think it is better to put python to 3.11 rather than using a backport feature ?
There was a problem hiding this comment.
from typing_extensions import Self is already used through the code
But you're right, let's upgrade python!
There was a problem hiding this comment.
Ah I have not seen that typing_extensions was already use
JulesL2
force-pushed
the
JulesL2/2lines_layout
branch
from
d502c4c
to
1c5f08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support of the switch from single line to 2 lines stat panel as worked here:
#45
Now the solution is less expensive as we recalculate only the panels elements