quality_data: overview: Fix incorrect field summing passing grants #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mariongalley the impact of this fix is that three metrics will be corrected significantly on https://qualitydashboard.threesixtygiving.org/alldata#grants :
|
|
I've created #248 as we need some worse quality test data to get better nuances on automated quality tests in the datastore for this, currently the totals generally add up to either 0% or 100% which can too easily coincidentally happen. |
R2ZER0
reviewed
Dec 16, 2024
When calculating the overview stats for /api/dashboard/overview?mode=grants the logic of fail/pass was being used to count the total number of grants which passed by just using the total number of grants that are in the source file. This is only correct some of the time because it just so happens that if a publisher is likely to be missing a field (such as company number) then they will miss it out of all of their datasets so the calculation is coincidentally correct. Some publishers however do add such fields for _some_ of their grants which makes this calculation completely incorrect for certain metrics. This change makes sure we use the total count from the DQT (library) rather than the aggregated data. Updates basic test data to corrected value. Fixes: #246
michaelwood
force-pushed
the
mw/fix_quality_grants_overview_stats
branch
from
35ad43a to
f0beb5c
Compare
|
deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the overview stats for /api/dashboard/overview?mode=grants the logic of fail/pass was being used to count the total number of grants which passed by just using the total number of grants that are in the source file.
This is only correct some of the time because it just so happens that if a publisher is likely to be missing a field (such as company number) then they will miss it out of all of their datasets so the calculation is coincidentally correct. Some publishers however do add such fields for some of their grants which makes this calculation completely incorrect for certain metrics.
This change makes sure we use the total count from the DQT (library) rather than the aggregated data.
Updates basic test data to corrected value.
Fixes: #246