This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
add TDecodeException to pure python binary.py's write_struct #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truebit
reviewed
Jul 3, 2018
| @@ -2,8 +2,10 @@ | |||
|
|
|||
| from io import BytesIO | |||
|
|
|||
| import pytest | |||
There was a problem hiding this comment.
should not import a third-party package IMHO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pure python binary protocol will throw errors like this when it's unable to decode a value:
The cython version of the binary protocol throws more helpful errors like this:
This changes the pure python version to behave more like the cython version.
This PR also refactors
write_valinthriftpy/protocol/binary.pyto look similar toc_write_valinthriftpy/protocol/cybin/cybin.c.