Fix parsing issue #992
Merged
Fix parsing issue #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarlesky
reviewed
Jan 15, 2025
mkarlesky
reviewed
Jan 15, 2025
Remove redundant comment remover.
mkarlesky
reviewed
Jan 15, 2025
| @@ -28,7 +28,7 @@ def validate_test_build_directive_paths | |||
| # TODO: When Ceedling's base project path handling is resolved, enable this path redefinition | |||
| # path = File.join( @base_path, path ) | |||
| unless @file_wrapper.exist?(path) | |||
| error = "'#{path}' specified by #{UNITY_TEST_INCLUDE_PATH}() within #{test_filepath} not found" | |||
| error = "'#{path}' specified by TEST_INCLUDE_PATH() within #{test_filepath} not found" | |||
There was a problem hiding this comment.
Was hardcoding the macro name in logging messages intentional?
There was a problem hiding this comment.
Yes. I've turned the const into a proper regex to be used where necessary, and removed the const for the name of a feature, to be consistent with how other features are handled. A const containing a string identical to the name of a const doesn't provide further clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing issues with comment handling. (#978, #981, #985)