Fix ribbon going over sticky tiddler title #8096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
@pmario I did check the other PR, but the issue comes from the card container, not the ribbon itself. I'll check your rewrite to see if it solve the issue, and I'll close this PR if it's the case (edit: it doesn't)
I agree ! I was wondering if there was a reason why this was done this way |
|
Sorry my fault. I did see the fork-github-ribbon, but you posted the image of GettingStarted. My linked PR has nothing to do with your PR . Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolation:isolate;is added to the style for the card in order to prevent the ribbon from going in front of the title bar while in position sticky.before (without
isolation:isolate;):after (with
isolation:isolate;):I made a simplified demo of how isolation:isolate fix z-index issues: https://minimal-css.tiddlyhost.com/#snippet%2Ffixing%20z-index%2Fisolation