Skip to content

v2.9.2: fixing encoding, upgrading, improving styles and more
Compare
Choose a tag to compare
@YakovL YakovL released this 12 Feb 21:41
· 434 commits to master since this release
v2.9.2
08d7a83
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

This release's main goal was to fix the upgrading engine which entailed researching and refactoring the whole bunch of encoding convertion methods. The full list of changes:

  • fixed upgrading TW in FireFox when using TiddlyFox + fixed various potential issues with encodings (refactored en/decoding)
  • fixed download-saving of TWs with non-ASCII chars in Chrome, Chromium-based browsers and Safari
    • retested and closed #136
  • fixed file loading of empty files
  • fixed saving in IE 11 (but not browser detection for IE 11 yet)
  • fixed upgrade fail when updated TW's URL contains hash and made upgrading preserve initial query and hash in URL
  • updated URL to load the new core when upgrading (now points to classic.tiddlywiki.com/upgrade/), introduced txtUpgradeCoreURI option to upgrade from another source (like a locally downloaded TW)
    • to do: make it appear in the options panel when not set yet (or in the upgrade wizard directly)
  • added escaping to ' and " in macro params: now
    param1:'let\'s use "single quote"' param2:"let's use \"double quote\"" will result in param values
    let's use "single quote" and let's use "double quote" while previously one could only get
    let\'s use "single quote" and let's use \"double quote\" in labels etc
  • improved styles (see screenshots there), including:
    • removed excessive borders and improved paddings in backstage/wizards
    • substituted the "close" text on the button in message widget with a cross icon, added an automatical fallback to text for old FireFox (and some others)
    • shortened mainSaved message from "Main TiddlyWiki file saved" to "TiddlyWiki saved"
  • internal: did some refactoring/codestyle improvements
    • started introducing BEM into html and CSS (without removing old ids to keep backward compability with old themes). messageArea block refactoring is finished (although .messageArea__text a selector can't be converted into BEM). Naming convention: blockName, blockName__elementName, blockName_modifierName, blockName_modifierName-modifierValue, the latter is not used yet
    • codestyle improvements are still rather spontaneous; to do: introduce Prettier and start adding linting rules

For discussion, use the thread in the Google group and don't forget to create issues if there's any.

Assets 3
Loading