Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reader to napari-ndev #85

Merged
merged 12 commits into from
Oct 11, 2024
Merged

add reader to napari-ndev #85

merged 12 commits into from
Oct 11, 2024

Conversation

TimMonko
Copy link
Owner

The reader is modeled after napari-bioio.
It is intended to be updated in the future, but this initial pull allows functionality without depending on napari-aicsimageio (which had many dependency conflicts) nor does it utilize the unreleased napari-bioio, which cannot be used since it is yet to be added to pypi.

In the future, there will be a custom scene widget, and the ability to input parameters from the Image Utilities container to result in files opening in or out of memory, if possible, and to select layer type.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 64.67066% with 59 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (030671f) to head (505ab6f).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/napari_ndev/_napari_reader.py 59.55% 46 Missing and 9 partials ⚠️
src/napari_ndev/_tests/test_napari_reader.py 83.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   81.68%   80.31%   -1.37%     
==========================================
  Files          23       26       +3     
  Lines        1938     2103     +165     
  Branches      125      147      +22     
==========================================
+ Hits         1583     1689     +106     
- Misses        321      368      +47     
- Partials       34       46      +12     
Flag Coverage Δ
unittests 80.31% <64.67%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimMonko TimMonko merged commit 2cca448 into main Oct 11, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant