[Based on #25] Have encode() take its writer by value #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienG2
force-pushed
the
write-by-value
branch
2 times, most recently
from
7497d6e
to
12bf34f
Compare
HadrienG2
force-pushed
the
write-by-value
branch
from
12bf34f
to
0e6fac2
Compare
By its very nature, Abomonation does very unsafe (and UB-ish) things. But we should strive to explain these as well as we can in the current state of the unsafe Rust formalization effort in order to reduce the potential for known misuse.
HadrienG2
force-pushed
the
write-by-value
branch
from
0e6fac2
to
6c12b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement the change discussed in #20 because it's very easy to do, and a net API generalization with no known harmful side-effect. But depending on how the discussion in #23 goes, this PR may be scrapped entirely in favor of a more ambitious API redesign that resolves the pointer alignment problem once and for all.
For convenience reasons, this PR is based on #22, #24 and #25. Reviewing these PRs first is recommended, but if you want to review this one in isolation, please consider doing so commit-by-commit in order to get a clean diff.
Fixes #20 .