Fix service UUID filter and fix advertisement data get wiped when the advertisement is split #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 14, 2022 21:24
rickymohk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix service UUID filter issue (#18). by creating one watcher for each service UUID.
For the advertisement, since Windows may receive the advertisement in two parts when doing active scan (e.g. first part contains service UUIDs, second part contains manufacturer data), if the fields that don't exist are set to empty strings or empty arrays, the previously received data will get wiped. Non-existing field should not be set and Noble will merge the split parts together.