Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle canonical repo name for cquery #224

Merged

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Sep 16, 2024

Not directly address #196 but this fix is required to work with bzlmod where canonical repo name is used.

This doc talks about canonical name: https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit#heading=h.5mcn15i0e1ch

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@honnix
Copy link
Contributor Author

honnix commented Sep 16, 2024

@tinder-maxwellelliott Could you please take a look and see whether this makes sense? Thank you. I will look into how to get CLA signed.

@honnix
Copy link
Contributor Author

honnix commented Sep 17, 2024

I'm not exactly sure how long it would take me to get CLA signed, so please feel free to take this change (if it makes sense of course) to another PR and close this one. Thank you.

@honnix
Copy link
Contributor Author

honnix commented Sep 19, 2024

@tinder-maxwellelliott Thank you for approving this. As I said please feel free to take this change in a new PR and close this one. It would be great if you could drop a new release. Thank you.

@tinder-maxwellelliott tinder-maxwellelliott merged commit 9d8f546 into Tinder:master Sep 20, 2024
8 checks passed
@honnix honnix deleted the handle-canonical-repo-name branch October 2, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants