Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use consistent labels for cquery #244

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 9, 2024

Closes #238

Use --consistent_labels when cquery is used to make sure the outputs of starlark format aligns with proto format.

We could chose to always use --consistent_labels but it will be a breaking change for users who use query, bzlmod, and set --fineGrainedHashExternalRepos.

Strictly speaking, this is also a breaking change for users who use cquery, bzlmod, and set --fineGrainedHashExternalRepos, but since bazel_diff doesn't really work for this combination (see #238), I think it is acceptable.

I modified those two zip files adding common --java_runtime_version=remotejdk_11 to .bazelrc, otherwise cquery would fail.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@honnix
Copy link
Contributor Author

honnix commented Oct 9, 2024

I'm not entirely sure this change is reasonable, so please let me know if something doesn't make sense. Thanks.

Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tinder-maxwellelliott tinder-maxwellelliott merged commit a0975b9 into Tinder:master Oct 9, 2024
8 checks passed
@honnix honnix deleted the consistent-label branch October 9, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cquery starlark output missing dependencies
3 participants