Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set up ktfmt to format code #247

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 22, 2024

This might be controversial but it has been something I always struggle with :).

The first commit is adding Bazel support and the second is the reformatting itself.

bazel run format does the job.

If this gets merged, I think we can have a .git-blame-ignore-revs file to ignore the commit reformatting code.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@honnix honnix marked this pull request as ready for review October 22, 2024 19:28
Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for adding it

@tinder-maxwellelliott tinder-maxwellelliott merged commit 71bec22 into Tinder:master Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants